Node shutdown not implemented sufficiently

[Gerrit91]

I saw in #71 that we implemented machine shutdown like:

// InstanceShutdown returns true if the instance is shutdown according to the cloud provider.
// Use the node.name or node.spec.providerID field to find the node in the cloud provider.
func (i *InstancesController) InstanceShutdown(ctx context.Context, node *v1.Node) (bool, error) {
	klog.Infof("InstanceShutdown: node %q", node.GetName())
	machine, err := i.MetalService.GetMachineFromProviderID(ctx, node.Spec.ProviderID)
	if err != nil || machine.Allocation == nil {
		return true, err
	}
	return false, nil
}

We can really tell if a machine is shut down through the machine IPMI information now, so we could adjust that information.

[majst01]

I am not sure if this is better, from the kubernetes perspective a machine without a allocation is not usable anymore. If it is powered down it might come back ??

[Gerrit91]

I think so. Why the interface has this function I am not sure, but from their tests it looks like this is the information they want to have (e.g. https://github.com/kubernetes/cloud-provider/blob/4aee77fb09241781309a244eea3b6bd4bd26b0c3/controllers/nodelifecycle/node_lifecycle_controller_test.go#LL650C10-L650C83).