String concat example #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @crisptrutski and the rest of your teammates on |
piranha
reviewed
Jul 9, 2024
tsmacdonald
reviewed
Jul 10, 2024
| :source-columns [{:table "t" :column "x"} | ||
| {:table "t" :column "y"}] | ||
| :columns [{:table "t" :column "x" :alias "z"} | ||
| {:table "t" :column "y" :alias "z"}]} |
There was a problem hiding this comment.
Does the text fixture need to be loaded in a test file, or does it (now?) auto-load everything it finds?
There was a problem hiding this comment.
Yeah there's magic - we loop over all the sql files in this directory, and check whether they have corresponding EDN files. The more EDN files you have, and the more you have in them, the more assertions we autogenerate ✨
There was a problem hiding this comment.
There was a problem hiding this comment.
I was curious so just checked - we currently have 45 assertions being generated by 17 fixtures.
tsmacdonald
approved these changes
Jul 10, 2024
crisptrutski
force-pushed
the
string-concat
branch
from
e30f501
to
b09fcb2
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to reproduce a failure, but could not. Added a test demonstrating that it works (now?)