Update homebrew formula to depend on [email protected] #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `[email protected]` is now the default when the formula aliases `python` or `python3` are used: https://formulae.brew.sh/formula/[email protected] As such, many other formulae are already using `[email protected]`, so updating to it for this project reduces the chance users will end up having to have two different Python versions installed. Given that now: 1. `crosstool-ng` has already updated it's own `depends_on` to `[email protected]` 2. The Python command alias here has been set to `python3` via `CT_GDB_CROSS_PYTHON_BINARY` in the various `.config`s ...I'm hopeful this should be more successful than when I attempted a Python version bump to 3.11 in messense#20 :-)
|
Thank you! |
|
FYI, this has been released in v13.3.0. |
|
Thank you 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
[email protected]is now the default when the formula aliasespythonorpython3are used:https://formulae.brew.sh/formula/[email protected]
As such, many other formulae are already using
[email protected], so updating to it for this project reduces the chance users will end up having to have two different Python versions installed.Given that now:
crosstool-nghas already updated it's owndepends_onto[email protected]: https://github.com/Homebrew/homebrew-core/blob/46db7ec181fbe0857089cadaff91ab1373577bdb/Formula/c/crosstool-ng.rb#L36python3viaCT_GDB_CROSS_PYTHON_BINARYin the various.configs: https://github.com/search?q=repo%3Amessense%2Fhomebrew-macos-cross-toolchains%20CT_GDB_CROSS_PYTHON_BINARY&type=code...I'm hopeful this should be more successful than when I attempted a Python version bump to 3.11 in #20 :-)