Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listing messages accepts conversationId instead of contactId #120

Open
lorenzosani opened this issue Apr 28, 2023 · 0 comments
Open

Listing messages accepts conversationId instead of contactId #120

lorenzosani opened this issue Apr 28, 2023 · 0 comments

Comments

@lorenzosani
Copy link

messagebird-nodejs/types/index.d.ts

Line 240 in 2d8b7de

contactId: string,

When calling MessageBird.conversations.listMessages, the call doesn't work if a contactId is passed, but works when the conversationId is passed. I believe this behaviour is correct, but the parameter name should be changed from contactId to conversationId if this is the case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorenzosani