Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(harbor): cert-manager internal tls #3083

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mhrabovcin
Copy link
Contributor

What problem does this PR solve?:

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mhrabovcin mhrabovcin requested a review from jimmidyson January 30, 2025 15:38
@mhrabovcin mhrabovcin self-assigned this Jan 30, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 30, 2025
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2025
@coveralls
Copy link

coveralls commented Jan 30, 2025

Pull Request Test Coverage Report for Build 13060938096

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 13051681585: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@jimmidyson
Copy link
Contributor

Looks good but wondering what behaviour of harbor is when certs get renewed?

@mhrabovcin
Copy link
Contributor Author

@jimmidyson good catch, I've added reloader annotations.

@jimmidyson
Copy link
Contributor

@jimmidyson good catch, I've added reloader annotations.

Before doing that let's check if it reloads certs please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off services/harbor size/L Denotes a PR that changes 100-499 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants