Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update traceroute list naming #993

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjpetit
Copy link
Contributor

@bjpetit bjpetit commented Nov 15, 2024

What changed?

This change updates the naming of traceroute entries based on the number of hops towards and back.

  • Instead of 0 hops, direct will be shown
  • Pluralization of hop is handled in all cases
  • If the hops out and back are the same, "x Hops" would be shown
  • If the hops out and back are different, "x Hops Towards y Hops Back" will be shown

Why did it change?

This makes the description of traceroute items a bit more consistent.

How is this tested?

Ran through numerous permutations of traceroutes to ensure the naming was correct.

Screenshots/Videos (when applicable)

2638AD05-2B60-4C0E-AF55-9873586870F0_1_201_a

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant