Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensibility of Library #77

Open
RobTS opened this issue Feb 16, 2019 · 1 comment
Open

Extensibility of Library #77

RobTS opened this issue Feb 16, 2019 · 1 comment

Comments

@RobTS
Copy link

RobTS commented Feb 16, 2019

Hi there,

I really enjoy this photo viewer but am encountering some limitations, hence I would like to make some suggestions.

My issue is that I want to cache the images displayed locally, but can only either load all of them beforehand or have to display them from URL due to the fact that once the Photo Viewer is open, updates to its properties seem not to be recognized.

I have found related issues, such as #6, #43 and #61 that could all be done if there was a way to feed your own asynchronous supply of images to the library. An example: I know I have four pictures, but provide four promises for them instead of the actual file/web url. Once the promise is called, I can download uncached files or find the cached filename and serve it to the photo viewer. This could be tied into one's custom caching solution or something like Fast Image. Even better, you could have a small placeholder image and update it to the real one once provided.

Let me know if this is something you want to add in the future. So far, I took a quick look inside the library and it looks like most of these changes will need to be done on the native side, as the JS side works as expected (state updates trigger refreshes).

@BANG88
Copy link
Member

BANG88 commented Feb 18, 2019

Hi @RobTS I am glad you enjoy this package. PR are always welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants