[Cherry 4.0.x]: Proper cleanup of HTTP leftovers #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chine To make sure we always cancel the update download in case of an error. We need to be able to handle HTTPS/network/... errors as well as artifact parsing errors (incl. checksum mismatches,...). Instead of adding `download_client->Cancel()` calls to many places and risking missing some more, we introduce a new state the UpdateDownload state transitions into on failure and then things continue to the `download_error` state that handles the related state scripts, etc. Ticket: MEN-7810 Changelog: Fix download failure to always do a proper cancellation and cleanup of internal HTTP stuctures to avoid breaking future HTTP requests. Fixes `bad_version` error. Signed-off-by: Vratislav Podzimek <[email protected]> (cherry picked from commit f637498)
…resumer The `http::Client()` class is designed to always have only one HTTP request in progress. Thus, before scheduling a new request using the same `http::Client` instance, cancel the previous request to make sure everything is properly reset for the new one. Ticket: MEN-7810 Changelog: Fix download resuming to reset the HTTP state and avoid repeatedly hitting the same error in case of a bad state Signed-off-by: Vratislav Podzimek <[email protected]> (cherry picked from commit 6a0c890)
|
Merging these commits will result in the following changelog entries: Changelogsmender (cherry-4.0.x-http_resumer_leftovers)New changes in mender since 4.0.x: Bug Fixes |
|
@mender-test-bot, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
lluiscampos
approved these changes
Dec 12, 2024
|
@mender-test-bot start pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-1586086638 Build Configuration Matrix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of PR: #1712
For you :)