Proper cleanup of HTTP leftovers #1712
Conversation
|
@vpodzime, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
|
@lluiscampos please start an appropriate pipeline here to check it doesn't break anything, at least. To verify it actually fixes something we'll need some new test(s). |
There was a problem hiding this comment.
The two fixes look good to me. Excellent work.
On the first commit, I would extend the changelog entry to include the actual error log printed by the client. So append something like: "... Fixes bad_version error."
@lluiscampos please start an appropriate pipeline here to check it doesn't break anything, at least. To verify it actually fixes something we'll need some new test(s).
This needs to wait. For unrelated reasons the pipeline is not working ATM
|
It seems to behave now... @mender-test-bot start pipeline 🤞 |
|
Hello 😺 I created a pipeline for you here: Pipeline-1583452424 Build Configuration Matrix
|
vpodzime
force-pushed
the
http_resumer_leftovers
branch
from
69a171a to
189c667
Compare
Done. |
|
@vpodzime Rebase on top of latest master to get the CI fixes 👍 |
…chine To make sure we always cancel the update download in case of an error. We need to be able to handle HTTPS/network/... errors as well as artifact parsing errors (incl. checksum mismatches,...). Instead of adding `download_client->Cancel()` calls to many places and risking missing some more, we introduce a new state the UpdateDownload state transitions into on failure and then things continue to the `download_error` state that handles the related state scripts, etc. Ticket: MEN-7810 Changelog: Fix download failure to always do a proper cancellation and cleanup of internal HTTP stuctures to avoid breaking future HTTP requests. Fixes `bad_version` error. Signed-off-by: Vratislav Podzimek <[email protected]>
…resumer The `http::Client()` class is designed to always have only one HTTP request in progress. Thus, before scheduling a new request using the same `http::Client` instance, cancel the previous request to make sure everything is properly reset for the new one. Ticket: MEN-7810 Changelog: Fix download resuming to reset the HTTP state and avoid repeatedly hitting the same error in case of a bad state Signed-off-by: Vratislav Podzimek <[email protected]>
vpodzime
force-pushed
the
http_resumer_leftovers
branch
from
189c667 to
6a0c890
Compare
Done. |
|
Merging these commits will result in the following changelog entries: Changelogsmender (http_resumer_leftovers)New changes in mender since master: Bug Fixes |
|
The previous pipeline was 🟢 - and since then the rebase updates did not bring software changes. Merging. |
|
Hello 😺 This PR contains changelog entries. Please, verify the need of backporting it to the following release branches: |
|
@mender-test-bot cherry-pick to:
|
|
Hi 😺 |
No description provided.