Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image orientation (config issue and feature request) #33

Open
ppescher opened this issue Aug 8, 2024 · 2 comments
Open

Image orientation (config issue and feature request) #33

ppescher opened this issue Aug 8, 2024 · 2 comments

Comments

@ppescher
Copy link

ppescher commented Aug 8, 2024

Thanks for maintaining this extension, I really appreciate.

I have a weird behavior on Thunderbird 128.1.0 (Windows 11 x64), but I'm not sure if it happened before. The extension setting "auto orientation" (under EXIF) does not activate: it is not checked by default and every time I click it is immediately deactivated (check mark disappears).

Other than that, what could be very useful would be an option to manually specify rotation for images, even if EXIF data is not present. Rotation support is already there, maybe it's not that hard to implement this feature.

@memeller
Copy link
Owner

memeller commented Aug 8, 2024

I have just checked and could not reproduce the reported problem using TB 128.1.0 and version 5.8.2 of the addon.
Do other options work fine? Did it work before? Can you remove the addon, restart TB and reinstall it to see if the problem persists?

Regarding the rotation setting - currently the addon only supports EXIF rotation. It does not check the width and height of the image, it simply checks if the exif contains orientation data and applies the rotation based on the exif orientation value.
I suppose in the future I could add an option to include an additional rotation parameter, set by the user in the resize dialogue. This would require small changes in other files, but I guess it could be done.

@ppescher
Copy link
Author

ppescher commented Aug 8, 2024

I have just checked and could not reproduce the reported problem using TB 128.1.0 and version 5.8.2 of the addon.
Do other options work fine? Did it work before? Can you remove the addon, restart TB and reinstall it to see if the problem persists?

Sorry about that. For some reason I had the old version 5.1.2 installed. I reinstalled and it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants