-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance bootup logging to include detailed rule information #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add additional logging when the router starts to display the number of rules and their details, including names and specific configurations for APIProxy and SOAPProxy. - Implement helper methods to format rule display names and custom names for better clarity in logs. - Update `InternalProxy` initialization to use `StringUtils` for key generation.
This pull request needs "/ok-to-test" from an authorized committer. |
/ok-to-test |
Implement methods to format and group OpenAPI records by directory. Enhance the display output to include detailed location information when OpenAPI records are present.
- Create a new test class `OpenAPI31ReferencesTest` for validating OpenAPI 3.1 references. - Implement setup method to initialize the router and load OpenAPI specs. - Update test cases to handle requests for both `/pets` and `/users` endpoints. - Modify the existing OpenAPI specification to include server information in the YAML configuration.
# Conflicts: # core/src/test/java/com/predic8/membrane/core/openapi/serviceproxy/OpenAPI31ReferencesTest.java # core/src/test/resources/openapi/specs/oas31/request-reference.yaml
# Conflicts: # distribution/examples/security/api-key/simple/README.md # distribution/examples/security/api-key/simple/proxies.xml # distribution/examples/security/api-key/simple/requests.http
# Conflicts: # distribution/conf/proxies.xml
# Conflicts: # core/src/main/java/com/predic8/membrane/core/Router.java # core/src/main/java/com/predic8/membrane/core/proxies/RuleDisplayInfo.java # core/src/main/java/com/predic8/membrane/core/rules/InternalProxy.java
…e code clarity - Remove redundant method for additional proxy display name and consolidate logic - Enhance formatting for OpenAPI and WSDL information in log output - Streamline location info formatting to improve readability - Remove unused methods and imports to clean up the code
- Add the Cloneable interface to OpenAPISpec and Rewrite classes. - Implement custom clone methods to ensure deep copying of mutable fields. - Modify OpenAPIRecordFactory to utilize the cloned OpenAPISpec when creating records. - Update logging in ProxyDisplayInfo to reflect enhanced proxy information.
…stead of 'api' method in internal service routing tests.
predic8
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.