Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default chunk for manager_locked_message #1

Open
wuuti opened this issue Feb 17, 2015 · 5 comments
Open

Provide default chunk for manager_locked_message #1

wuuti opened this issue Feb 17, 2015 · 5 comments
Assignees
Milestone

Comments

@wuuti
Copy link

wuuti commented Feb 17, 2015

It would be helpful if the package provided a chunk for the manager_locked_message by default.

@rtripault
Copy link
Member

Hi Jens,

Not sure to get what problem that would solve, save some time ?

For now it makes use of https://github.com/meltingmedia/Locker/blob/master/core/components/locker/lexicon/en/default.inc.php#L5 lexicon key (see relevant code)

@wuuti
Copy link
Author

wuuti commented Feb 17, 2015

Mhh... ok, it would only save a tiny bit of time. But I do not like markup being stored in lexicons - having a default chunk with

<div class='warning'>[[%locker.manager_locked_message]]</div>

could separate the pure translations into the lexicons and the markup into the chunk.

@rtripault
Copy link
Member

Makes sense, so on it :)

@rtripault rtripault added this to the v0.1.x milestone Feb 17, 2015
@rtripault rtripault self-assigned this Feb 17, 2015
rtripault added a commit that referenced this issue Feb 18, 2015
@wuuti
Copy link
Author

wuuti commented Sep 2, 2015

Is 0.1.1 getting ready?

@rtripault
Copy link
Member

Woups. Project went completely under my radar, but will try to release an update in the coming days!
Thanks for reminding me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants