Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Search by plugin variant/maintainer #1717

Open
ReubenFrankel opened this issue Mar 19, 2024 · 2 comments
Open

feat: Search by plugin variant/maintainer #1717

ReubenFrankel opened this issue Mar 19, 2024 · 2 comments

Comments

@ReubenFrankel
Copy link
Contributor

ReubenFrankel commented Mar 19, 2024

It would be nice to be able to search for plugins by variant/maintainer.

image

Also, there is an small issue where if the search term matches both a keyword and a plugin name (i.e. matatika), depending on the type of plugin, the one with the matching name is forced down the search results list. This feature could also address this by respecting the defined order of plugin text fields to search by (i.e. name, then label, then variant, and so on).

image
image

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Mar 21, 2024

It would be nice to be able to search for plugins by variant/maintainer.

fwiw that's probably an easy win with little changes to the graphql query and the joined text fiels in Search.vue

Also, there is an small issue where if the search term matches both a keyword and a plugin name (i.e. matatika), depending on the type of plugin, the one with the matching name is forced down the search results list. This feature could also address this by respecting the defined order of plugin text fields to search by (i.e. name, then label, then variant, and so on).

but this is probably a heavier lift if I understand it correctly. Does this mean something like "if the plugin name matches the search term, then show it first regardless of plugin type"?

The problem is that for historical (i.e. tech debt) reasons, search terms are currently matched against a concatenation of a bunch of plugin fields into a single string.

@ReubenFrankel
Copy link
Contributor Author

fwiw that's probably an easy win with little changes to the graphql query and the joined text fiels in Search.vue

Yeah, I did have a look and making variant searchable is pretty simple, but in the case of matatika the actual utility with that name is sorted below a bunch of our extractors (hence the other requirement).

Does this mean something like "if the plugin name matches the search term, then show it first regardless of plugin type"?

Yep, pretty much - maybe for label too. I was thinking about ordering plugins by the type of the text field (i.e. name or description) the search term best matches, but I can't say how complex that would be to implement or how performant it will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants