Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mention in readme that rails has implemented masking now? #22

Open
nruth opened this issue Oct 18, 2015 · 1 comment
Open

mention in readme that rails has implemented masking now? #22

nruth opened this issue Oct 18, 2015 · 1 comment

Comments

@nruth
Copy link

nruth commented Oct 18, 2015

I got here through the blog, and it seems masking has been merged into rails now (4.2 from comments in pull reqs, but I haven't checked). It'd be helpful for others discovering this the same way if the readme mentioned that rails has some part of this built in now: masking in rails/rails#16570 (but not rails/rails#11729 )
@swelther
Copy link

Adding a hint to the readme would be nice, yes.

But we still "need" this gem for the random length HTML comments right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nruth @swelther