Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition away from rgeos dependency? #6

Open
FMKerckhof opened this issue Oct 12, 2021 · 3 comments
Open

Transition away from rgeos dependency? #6

FMKerckhof opened this issue Oct 12, 2021 · 3 comments

Comments

@FMKerckhof
Copy link

Dear,

I was wondering how flowDensity will deal with the "retirement" of rgeos by 2023 (see https://cran.r-project.org/web/packages/rgeos/index.html) - is there a plan to change the imports gIntersects, gDifference and gBuffer to different dependencies?

@mehrnoushmalek
Copy link
Owner

Hi @FMKerckhof, Haven't thought about it yet but will need to change these at some point ( probably by early next year though).
Is there any concern?

@FMKerckhof
Copy link
Author

FMKerckhof commented Oct 12, 2021

Hi @mehrnoushmalek : I am making the transition from flowAI towards flowCut which is dependent upon flowDensity - one of the factors that I am trying to consider is the reliance upon dependencies. I already made a fork to experiment with sf::st_intersect, sf::st_difference and sf::st_buffer but it appears the sf implementation has a few idiosyncrasies that I need to get a better feel of (they are not drop-in replacements for rgeos). I'll keep you posted if I get it working and maybe send out a PR then.

@mehrnoushmalek
Copy link
Owner

@FMKerckhof That's right, but I think flowCut uses deGate from flowDensity, and you can technically import that to ignore rgeos.
But let me know if you find a way, and I'll see if there are other packages that do what I need from rgeos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants