Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the modules and unlock them #10

Closed
wants to merge 2 commits into from
Closed

Conversation

Jonne
Copy link
Contributor

@Jonne Jonne commented Dec 19, 2014

Hi, to be able to use composite DSC resources I had to copy them to the program files \ modules folder. This is the only way I could get it to work.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling fa8e50b on Jonne:master into 7cf22fd on mefellows:master.

@mefellows
Copy link
Owner

Thanks Jonne - have you got a sample DSC script I can use to test to reproduce the scenario? Or better yet, could you submit a working PR with an updated Vagrantfile setup?

I'm happy to improve test coverage etc. The more scenarios etc. we get in there the better.

As an FYI, I'm looking to see if there is a way to provision a Vagrant box during CI.

@Jonne
Copy link
Contributor Author

Jonne commented Jan 6, 2015

Hi Matt, I added a sample DSC script with composite DSC resource.

@mefellows
Copy link
Owner

Thanks Jonne, this is much appreciated. I'll take a look at this over the next few days and run it by a few colleagues.

@mefellows
Copy link
Owner

Hi Jonne,

I have taken a look at this PR. Correct me if I'm wrong, but doesn't the current example already show the use of a Composite resource? The SimpleWebsite Configuration in the MyWebApp Module is a Composite resource used by the MyWebsite.ps1 manifest in much the same way as the CommonConfigModule.ps1 of your PR.

For me, I am able to vagrant up with this configuration with no problems. Are you using a different OS or WMF version? Perhaps the issue is portability across different Windows setups?

@Jonne
Copy link
Contributor Author

Jonne commented Jan 7, 2015

You are right, I didn't have the latest version, sorry for that. The composite resource looks good indeed.

However if i try to vagrant up that one I get the following error:

The following WinRM command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

mkdir c:\ -force
if ($?) { exit 0 } else { if($LASTEXITCODE) { exit $LASTEXITCODE } else { exit 1 } }

Stdout from the command:

Stderr from the command:

#< CLIXML
System.Management.Automation.PSCustomObjectSystem.Object1<PR N="Record"

Preparing modules for first use.0-1-1Completed-1 </
PR>mkdir : The path is not of a legal form.x000D__x000AAt line:1 char:1_x000D
x000A
+ mkdir c:\ -force_x000D__x000A+ ~~~~~~~~~~~~~~~~x000D__x000A + CategoryInfo : InvalidArgument: (C::String) [New-Item], Argume x000D__x000A ntEx
ception_x000D__x000A_
+ FullyQualifiedErrorId : CreateDirectoryArgumentError,Microsoft.PowerShel x0
00D__x000A
l.Commands.NewItemCommand_x000D__x000A_ x000D__x000A

@mefellows
Copy link
Owner

Hi Jonne, no worries at all.

Please see PR #13 for the latest changes, including a couple of bug fixes and the suggestion of yours in this PR to 'unblock' modules in advance.

For better tracking, of your specific problem, I've migrated the defect to issue #14.

For now, I will close this PR whilst we address the issue, we can always re-open later if need be.

@mefellows mefellows closed this Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants