-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package being detected as a virus #186
Comments
@aviramha there's no virus in this package. Please report the issue to the VS Code. Added later: I'll be happy to report this issue to any anti-virus or security service, yet I need precise instructions from you on where I can do it? I'm not aware of any reports on my own (my work and my personal digital life are not affected by it). Please post instructions as comments in this thread. Thank you! |
I know there's no virus. It's also not VS Code probably as more than 1 anti viruses detect it s a virus. I'd assume contacting each anti virus but I'm really pessimistic about Kaspersky not tagging this as a virus. |
We emailed the marketplace team BTW, but given past experience, as written before I wouldn't hold my breath. |
@aviramha thanks for emailing them. AFAIK it's Kaspersky (Russian anti-virus) that does this kind of thing, but it's also discouraged to rely on this antivirus now (many sources warn against using it). So I guess VS Code might have fallen in to trap of relying on it (or on the antivirus that uses its database). They really should fix it. |
The problem is that this package is doing more than it advertises. It not only extends es5 with extra methods and shims, it also implements a "Call for peace" message. I think it's an unacceptable practice that slows done installation process. https://github.com/medikoo/es5-ext/blob/main/_postinstall.js I discovered it as Send more weapons to Ukraine and beat the Ruskis but do not pollute my dev environment. And I am saying this with a complete recognition that Russia is the warmonger. |
So the real reason this is a virus is that it's doing needless postinstall actions that depend on the location of the user. What next? If somebody is in Russia, maybe delete all of their files? How much more evil do Ruskis need to do for this to become OK? |
Kaspersky Anti-Virus also detects the package as a virus:
Original:
I think it's because of this text: https://github.com/medikoo/es5-ext/blob/main/_postinstall.js#L31-L72 Released in 0.10.54: 28de285 |
@andrey-helldar yes, Kaspersky is Russian-based and no longer a credible anti-virus resource. There's widespread advice to not rely on it anymore (e.g. https://www.komando.com/security-privacy/kaspersky-antivirus-dangers/830542/). So if you're affected by the fact that Kaspersky reports this package, ensure to not rely on Kaspersky in the first place. |
Note that I will delete any off-topic responses. The topic here is that some anti-virus software (such as Kaspersky) are reporting as if the package is containing a "virus" which is not the case. This package, in certain scenarios, just prints a short message on installation. Respond only if you have information on other anti-virus software that reports it, or have success stories on removing dependency on that specific anti-virus software. |
I would like to add on my own: there are two ways to solve the problem: First way: to do this, go to the "Exceptions" section in the settings and add four entries:
In all points, I selected "Scan area" - "everything" ( After that, the antivirus stopped responding to this error. Second way: delete Kaspersky from PC. PS: This file does not contain any virus, and the antivirus reacts because it belongs to a Russian company. In Russia, any anti-war statements are punishable by law. In addition, it has long been known that Kaspersky Anti-Virus works for the government. |
I don't have any more information, just wanted to point out that all of the accounts that are downvoting you are very suspicious. Most don't even have more than 3 contributions. This is crazy. |
Without commenting on the message itself, since at the end of the day, this is the maintainers repo. If anyone else is being negatively affected by usage of this repo, such as my team and I were, with many many user reports and accusations of our code being malicious, one thing that can be done to resolve it, is to fork this repo, and remove the offending code like seen here, then in whatever repo you are concerned about you can set a "resolutions": {
"es5-ext": "https://github.com/YOUR_ORG/es5-ext"
} Again, I want to clarify, this isn't meant to attack or disagree with the maintainers of this repository, this is simply educational. Since while in this issue the stated answer is to not trust Kapersky, that isn't something that could potentially be told to users who won't install or use software because of this. Additionally, if any software relies on this package and is being flagged via Google Chromes Advanced Protection, there's evidence to support that this is also the cause of it. In which case Google Chrome will stop the download entirely. |
Sonatype starts flagging the library as "malicious". Sonatype Firewall therefore blocks it. |
Whitelisting the package is risky, because it would create a false negative, when this repo is e.g. hacked and really contains malicious code. |
@robert-gdv have you reported the issue to Sonatype? (there's nothing malicious about the package) |
Sonatype refuses to remove this issue from their malicious list
Using the Waiver is a good solution in this case, because the ID sonatype-2022-2248 covers this issue with the packet. The Waiver would not hide other issues with this package. |
Thanks, @robert-gdv, for reaching out to Sonatype. Interestingly, there are other packages that present welcome messages during installation, which are also not intended by users who install them (e.g., sponsorship ads). Yet, I never saw them being reported by anti-virus software. Also, in this package case, it targets a specific group. It's not the noise that is presented to everyone. |
My request to Sonatype to remove this malicious flag was denied. I will not follow up on that. It is just not important enough. |
I'm unable to use Evernote because of this issue. Will obviously report about the problem to Evernote team. |
@alexguevara report at DrWeb, as this package doesn't do anything malicious that should be a concern. It just conditionally displays a friendly short message when you install it (not when you use it), and note that hundreds of other npm packages do the same. So marking this packing as dangerous is simply incorrect. |
But the impact of the classification is that many people cannot use the module, are inconvenienced by false positive flags or have to take special actions to whitelist it on every system it runs on. This is a dumb hill to die on |
I've added extra explanation in top description |
The problem is it's presence, not it's context |
@medikoo not sure if you'd like to lock this issue as there's no more helpful discussion. |
Note from the maintainer:
This package conditionally displays a friendly message when installed via npm.
The message appears only if the computer's locale timezone is set to one of the Russian timezones and politely advises users to seek reliable sources of truth regarding the war in Ukraine. The message is short and concise.
Note that it is not uncommon for npm packages to print some information upon installation. Hundreds of packages on npm do this: https://github.com/search?q=%22%5C%22postinstall%5C%22%22+language:json&type=code. Are they reported by any anti-virus software?
This post-install logic is not part of the package's core functionality. It does not affect how the package operates when used. If you rely on a prepackaged product that depends on this package, this logic is not included in your product.
At worst, this behavior could be considered protestware, but labeling it as dangerous to users is simply incorrect. If any anti-virus software flags this behavior, please report it to them, as this is a bug on their side that unnecessarily complicates your experience.
Original post:
We updated our version of es5-ext and faced an error when publishing to VS Code marketplace when they ran anti virus scan.
Checking it offline, we found out that VirusTotal started detecting the version with the manifest as a virus, hence forcing us to stay with last version before manifest.
I don't wish to get into the politics and decision - I believe this is entirely up to the package creator and maintainer to decide as it's their software, but opening this as a FYI.
The text was updated successfully, but these errors were encountered: