attempt to put in more default values for more happy path #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hareet
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Cool !
And this is how we handled uuid in user-management charts that we would want to bring over to cht-core-4x charts if you have time/interest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to help out with medic/medic-infrastructure/pull/1078
Note: in other values files we go with default
uuidandsecretvalues. I think this OK for ephemeral dev instances as per this PR, but for prod instances we should go with uniqueuuidgenoutput for both values.