-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom partitions, allow numbered directories for subPath for multiple nodes #25
Conversation
…s for clustered setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get it in there!
Some clarification around scenarios that use numbered directories for subPath and we could write that note about which scenario in values.
{{- if $.Values.couchdb_data.dataPathOnDiskForCouchDB }} | ||
subPath: {{ if contains "%d" $.Values.couchdb_data.dataPathOnDiskForCouchDB }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this also parses data%directory
and may mess up the setup if data%directory
is provided and is a valid name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's technically allowed to use that as a directory name in linux, it's generally recommended to stick to more standard naming conventions like letters (a-z, A-Z), numbers (0-9), underscore (_), and hyphen (-). Avoiding spaces and special characters. We'll validate against special characters in directory names and passwords, user name etc when adding validation features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also making a note that across projects these are generally named like:
data
or /srv/storage/medic-core/couchdb/data
. The support we're introducing now is for when people setup clustered setup with k3s or docker-compose and have named the directories for individual couchdbs like /srv1/couchdb/data
(For couchdb1), srv2/couchdb/data
(For couchdb2) and srv3/couchdb/data
(For couchdb3).
I will add detailed notes about scenarios. |
srv%d
in the values. The code replaces %d with the node number.