Add PolymorphicComponentProps #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not extremely seasoned in writing tests for this particular kind of utility, but I would hazard that we'd need to test:
Input would be most appreciated. |
ThaNarie
reviewed
Dec 1, 2023
|
@mmnathan Could you check / maybe help with adding type tests? :) |
…rphicComponentProps.
# Conflicts: # src/index.ts
ThaNarie
approved these changes
Feb 10, 2024
leroykorterink
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a collection of generic types to help create strongly typed Polymorphic Components.
This came up while creating a Polymorphic component(which was easy) and then having to define types without knowing in advance which element was going to be the basis (which was a hassle). These types should make the process less of a chore.