Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create useIsInView #270

Open
VictorGa opened this issue Nov 14, 2023 · 1 comment
Open

Create useIsInView #270

VictorGa opened this issue Nov 14, 2023 · 1 comment
Assignees
@leroykorterink
Labels
enhancement New feature or request

Comments

@VictorGa
Copy link

Create a hook called useIsInView that uses the useIntersectionObserver.

This hook will return true/false for when the element passed is in view
@ReneDrie
Copy link
Contributor

The useIntersectionObserver hook used in our skeleton (see here is currently returning a boolean for the inView state which I use more than the callbacks personally.
Not sure if people agree that this should be the default, if not, then this hook would definitely be needed.
I think we need to find the best way one remove one implementation.

@leroykorterink leroykorterink self-assigned this Feb 9, 2024
@leroykorterink leroykorterink added the enhancement New feature or request label Feb 9, 2024
leroykorterink added a commit that referenced this issue Feb 9, 2024
@leroykorterink
Add useIsIntersecting and useIsIntersectingState hooks #270
294ad43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leroykorterink leroykorterink

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

270-create-useisinview mediamonks/react-kit
3 participants
@ReneDrie @VictorGa @leroykorterink