unicorn/prefer-native-coercion-functions doesn't work well with typescript and should be disabled.

[hjeti]

The Boolean part of this rule and the auto fix break my code, because they don't work well with typescript.

I write this:

const testArray = ['test', null];
        
const output = testArray.filter((value): value is string => Boolean(value));

and it converts it to this:

const testArray = ['test', null];

const output = testArray.filter(Boolean);

This is not the same. The type of output is Array<string> in my code and Array<string | null> in the 'autofixed' code.

[ThaNarie]

It seems there is an open issue for this: sindresorhus/eslint-plugin-unicorn#1857

Alternative option is to use isBoolean from isntnt, which is typeguarded.

But it seems that, until that issue is fixed, we should disable it.

[leroykorterink]

Typescript now infers type predicates properly, but with this change I think we should disallow the use of the Boolean constructor as an argument for the Array.filter function.

https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-beta/#inferred-type-predicates