Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderedOutputBuffer could handle backpressure to avoid overflowing memory #73

Open
Yomguithereal opened this issue Nov 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Yomguithereal
Copy link
Member

This would of course potentially slow everything down and could lead to nasty deadlocks if not implemented properly.

@Yomguithereal Yomguithereal added the enhancement New feature or request label Nov 3, 2023
@Yomguithereal
Copy link
Member Author

I think it does not slow down because of backpressure but ramp up memory usage. This is because task_done is called before the item is actually yielded downstream (which makes sense else it would incur some lock until the sink has finished processing an item. But we could give this power to the user to ensure atomicity wrt sink)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant