Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the takanaClient.run(); #47

Open
valtido opened this issue Oct 17, 2014 · 3 comments
Open

Removing the takanaClient.run(); #47

valtido opened this issue Oct 17, 2014 · 3 comments

Comments

@valtido
Copy link

valtido commented Oct 17, 2014

why is it necessary to have a second script tag to just run it ?

simply by including the first tag indicates the toggle notion whether you should run takana true|false?

or am I missing something ? (not a bug, just an open discussion)

@nc
Copy link
Contributor

nc commented Oct 18, 2014

@valtido takanaClient.run allows you set the hostname - which is required for testing on devices other than localhost. Say an iPhone on your local network.

@nc
Copy link
Contributor

nc commented Oct 18, 2014

@barnaby perhaps we need to explain how to use Takana with other devices?

@valtido
Copy link
Author

valtido commented Oct 20, 2014

Yes, Since they default to something else, maybe they should be a pre config json object to before the script. Just a suggestion :)

@nc nc added bug suggestion and removed bug labels Oct 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants