Reimplement undo/redo history to fix security warnings #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisvxd
force-pushed
the
fix-security-warnings
branch
from
632ff7d
to
e9aba48
Compare
chrisvxd
force-pushed
the
fix-security-warnings
branch
from
e9aba48
to
e51d316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #265
Description
This PR refactors the undo/redo history to avoid event listeners, fixing some security issues and streamlining how the history is stored.
This reimplementation will also make it easier to expose the undo/redo history to users via the
usePuckhook added in #265.Background
The
@measured/puckpackage is currently experiencing security warnings via socket.dev.These are caused by the
es5-extlibrary, which includes:es5-extwas introduced during #23 due to the usage of theevent-emitterpackage.