refactor: store entire history to improve undo/redo robustness #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
monospaced
approved these changes
Oct 17, 2023
Some scenarios were tripping up undo/redo history when implementing array field reordering. Presumably a race condition, as could not reproduce during unit tests. It turns out that we were storing the entire object for the forward history, anyway, so this needs revisiting.
chrisvxd
force-pushed
the
store-entire-history
branch
from
ff726a2 to
1211315
Compare
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please approve #153 first
Some scenarios were tripping up the undo/redo history because of the delta history that used
deep-diff.Specifically, this occurred when implementing array field reordering in #143, which caused the undo/redo to corrupt the ordering. Presumably a race condition, as could not easily reproduce during unit tests (which will be added in #143).
It turns out that we were storing the entire object in the forward history (rather than just the diff) anyway, so I decided to strip out
deep-diffand store the entire object for now. In future, we should revisit delta history.FYI @Yuddomack