Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor world elements cost calculation code #60

Open
mdziekon opened this issue Aug 28, 2019 · 1 comment
Open

Refactor world elements cost calculation code #60

mdziekon opened this issue Aug 28, 2019 · 1 comment
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup

Comments

@mdziekon
Copy link
Owner

It looks like a lot of places "manually" calculate world elements (buildings, ships, technologies) costs and other similar derivative values.

To prevent bugs caused by inconsistent implementations and get rid of code duplication, there should be a bunch of shared functions created only for this purpose.

TODO:

  • Create shared cost (and other similar derivative value calculating) getting functions
  • Use these new shared functions throughout the code
@mdziekon mdziekon added the enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup label Aug 28, 2019
@mdziekon mdziekon changed the title Improve world elements cost calculation functions Refactor world elements cost calculation code Aug 31, 2019
@mdziekon mdziekon mentioned this issue Aug 31, 2019
Closed
22 tasks
@mdziekon
Copy link
Owner Author

Parts of this task were introduced in #63 and its related PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor world elements cost calculation code mdziekon/UniEngine
1 participant
@mdziekon