Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Chat message rows background is annoying on new messages #231

Open
3 of 7 tasks
mdziekon opened this issue Jul 3, 2022 · 0 comments
Open
3 of 7 tasks

[BUG] Chat message rows background is annoying on new messages #231

mdziekon opened this issue Jul 3, 2022 · 0 comments
Assignees
Labels
bug:confirmed All bug reports that were reproduced, therefore confirmed to exist bug All bug reports

Comments

@mdziekon
Copy link
Owner

mdziekon commented Jul 3, 2022

Problem description

When reading chat messages, eg. catching up on previously written messages, and someone is publishing new messages in the meantime, it's slightly annoying when the background of the messages shift - the currently read message will shift to the adjacent message's background.

Engine details

  • Engine version:
    • version 1.1.0
    • commit f2f1847
  • Custom modifications:
    • Yes
    • No
  • Environment:
    • local
    • testing (inaccessible from the outside)
    • production (accessible from the outside world)
  • Configuration:
    • Game speeds: N/A
    • Debris settings: N/A
    • Any other relevant config entry: N/A

Steps to reproduce

Prerequisites:

  • Have ~50 messages in any chat room

Steps to reproduce the behavior:

  1. Scroll down to read older messages
  2. Focus on one message in particular (message X)
  3. Using another account, write new message in the same chat room

Expected behavior

  • Message X has the same background as before publication of the new message

Actual behavior

  • Message X's background has changed

Screenshots

N/A

Reproduction environment

Desktop:

  • OS: Any
  • Browser: Any
  • Version: Any

Additional context

  • Most likely caused by background applied using even or odd pseudoselectors on rows.
  • Should be fixable applying background color based on message ID's value (either even or odd).
@mdziekon mdziekon added bug:unconfirmed All new bug reports that are yet to be confirmed (eg. by providing more details) bug All bug reports labels Jul 3, 2022
@mdziekon mdziekon self-assigned this Jul 3, 2022
@mdziekon mdziekon added bug:confirmed All bug reports that were reproduced, therefore confirmed to exist and removed bug:unconfirmed All new bug reports that are yet to be confirmed (eg. by providing more details) labels Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed All bug reports that were reproduced, therefore confirmed to exist bug All bug reports
Projects
None yet
Development

No branches or pull requests

1 participant