Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session handling improvements #150

Open
mdziekon opened this issue Jan 11, 2021 · 0 comments
Open

Session handling improvements #150

mdziekon opened this issue Jan 11, 2021 · 0 comments
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup

Comments

@mdziekon
Copy link
Owner

Description TBD

TODO

  • Generate crypto-secure random token for the session instead of some weird hashed concatenation
  • Stop using md5() for session handling
@mdziekon mdziekon added the enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup label Jan 11, 2021
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Remove PHP5 support for good (from the docs)
3a519c2
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Move login page's display logic to a separate module
367cb56
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Remove the ability to login using $_GET, as it exposes passwor…
47d08e6 
…d via urls
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Create cookie related helpers
948c46e
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Create session cookie verifier as a stand alone function
7aa9275
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Use new session validator code in CheckUserSessionCookie()
d42fc69
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Simplify CheckUserSessionCookie() indentations by using short-…
4b9c4e6 
…circuiting
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Get rid of unsafe initialization
095128c
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Move rate limit updater to a separate function
2644ec0
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Move rate limit verification to a separate utility
c41aefb
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Fix secret word getter for non-root places
d9cfea0
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Verify session cookie in login using the existing utils
513f35e 
(don't reimplement & reinvent the wheel)
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Move session password hasher into a separate util
41f12a4
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Minor renaming for better explanation
8ec662d
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Create session cookie packer
6c336b2
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Use utility to create session cookie
d4a4f22
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Share the cookie parts separator
6c95d3e
mdziekon added a commit that referenced this issue Feb 8, 2021
@mdziekon
GH-150 Use correct name for the cookie part
3727c2a
mdziekon added a commit that referenced this issue Feb 9, 2021
@mdziekon
GH-150 Move cookie login handling to a separate unit of code
81c7a6c
mdziekon added a commit that referenced this issue Feb 9, 2021
@mdziekon
GH-150 Create cookie clearing utility
5eff7d6
mdziekon added a commit that referenced this issue Feb 9, 2021
@mdziekon
GH-150 Remove redundant cookie clearing
f7e3e8e
mdziekon added a commit that referenced this issue Feb 9, 2021
@mdziekon
GH-150 Reuse existing utility to check for cookie
7dc25c7
mdziekon added a commit that referenced this issue Feb 9, 2021
@mdziekon
GH-150 Bring back missing failed attemp ip & ua logging
d70b9ec
mdziekon added a commit that referenced this issue Feb 14, 2021
@mdziekon
GH-150 Move local ident login handling to a separate unit of code
2a81568
mdziekon added a commit that referenced this issue Feb 14, 2021
@mdziekon
GH-150 Remove unused module reference
5ce82d9
mdziekon added a commit that referenced this issue Feb 15, 2021
@mdziekon
GH-150 Move perma redirect to utils
7f2e6d0
mdziekon added a commit that referenced this issue Feb 15, 2021
@mdziekon
GH-150 Move language change handling into a separate util
1a4835e
mdziekon added a commit that referenced this issue Feb 15, 2021
@mdziekon
GH-150 Simplify errors handling
fe34381
@mdziekon mdziekon mentioned this issue Mar 18, 2022
Merged
6 tasks
mdziekon added a commit that referenced this issue Mar 18, 2022
@mdziekon
Merge pull request #173 from mdziekon/mdziekon/gh-150/registration-cl…
161e766 
…eanup-2

Registration cleanup (part 2)
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Move input normalization to a separate file
26a25cf
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Move username validation to a new mechanism
9f2ee3d
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Prepare to handle more than one input validation
5e0e624
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Validate password
a70afea
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Validate email
adbfe80
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Validate galaxy no
e97cf73
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Validate lang code
af837e7
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Validate rules acceptance
de35c27
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Move recaptcha validation to validation helper
7899914
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Minor code cleanups
ab468f9
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Fix validation of taken params
23a0f77
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Cleanup unnecessary variables
8a6193d
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
GH-150 Move mail change updates to a separate util
fcffe30
@mdziekon mdziekon mentioned this issue Mar 19, 2022
Merged
3 tasks
mdziekon added a commit that referenced this issue Mar 19, 2022
@mdziekon
Merge pull request #174 from mdziekon/mdziekon/gh-150/registration-cl…
6cbf6d1 
…eanup-3

Registration cleanup (part 3)
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Move all of the reg ajax code into a function
8c8e1e8
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Add missing global vars
d69294d
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Simplify code by short circuiting
442415f
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 More short circuiting
fc781a8
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Final short circuiting
1b932d5
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Pass input as arg to prevent hardcoding
35f0bfb
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Use simple returns & create separate sendResponse function
02054dd
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Limit shared variable usage when returning payload
2b78709
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Simplify messaging
b0c7f26
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Create errors mapper
e970a29
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
GH-150 Fix error field mapping
cb4ae9b
@mdziekon mdziekon mentioned this issue Mar 22, 2022
Merged
3 tasks
mdziekon added a commit that referenced this issue Mar 22, 2022
@mdziekon
Merge pull request #175 from mdziekon/mdziekon/gh-150/registration-cl…
c4a6b35 
…eanup-4

Registration cleanup (part 4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdziekon