Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor flight control #139

Open
mdziekon opened this issue Dec 6, 2020 · 0 comments
Open

Refactor flight control #139

mdziekon opened this issue Dec 6, 2020 · 0 comments
Assignees
@mdziekon
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup

Comments

@mdziekon
Copy link
Owner

mdziekon commented Dec 6, 2020

Summary

There's a lot of repetition in all steps of the flight control pages' code which can easily be shared for more consistent data flow management. This should reduce possibility of situations where one step is broken, but the previous one which does the same thing is fine.
@mdziekon mdziekon added the enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup label Dec 6, 2020
@mdziekon mdziekon self-assigned this Dec 6, 2020
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
GH-139 Add fleet array validator
fa1a8ef
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
GH-139 Use generic fleet array validator in fleet1.php
7808ca2
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
GH-139 Fix missing translation
ad44398
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
GH-139 Simplify fleet array unpacking in fleet2
d60fcce
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
GH-139 Reuse validateFleetArray in fleet2
1af17ed
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
GH-139 Simplify fleet array unpacking in fleet3
dc6f66b
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
GH-139 Reuse validateFleetArray in fleet3
57f10f7
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
GH-139 Simplify fleet remover entries creation
9152e19
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
GH-139 Use helper function to get storage capacity
9f89f41
@mdziekon mdziekon mentioned this issue Dec 7, 2020
Merged
2 tasks
mdziekon added a commit that referenced this issue Dec 7, 2020
@mdziekon
Merge pull request #140 from mdziekon/mdziekon/gh-139/flight-control-…
ae3dfbd 
…refactor-part01

Flight Control refactor (part 01) - Fleet array validation
mdziekon added a commit that referenced this issue Dec 9, 2020
@mdziekon
GH-139 Create getAvailableSpeeds helper
597d090
mdziekon added a commit that referenced this issue Dec 9, 2020
@mdziekon
GH-139 Use getAvailableSpeeds in fleet1
219559b
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Use getAvailableSpeeds in fleet2
665d7b9
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Use getAvailableSpeeds in fleet3
0438c8a
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Create union join data fetcher
febd7f2
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Create union join validator
0ab1ac0
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Delegate union joining validation to validateJoinUnion()
5b58e67
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Create shared hold time available options table
9812215
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Create separate mission hold validator
5fb3023
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Build available holding times selections dynamically
294b1d6
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Validate account's activation using helper function
f02bcef
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Use account activation helper function in rest of the fleet se…
cf4ee56 
…nding code
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Use user account activation function in display code as well
ecb0b14
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Use getAvailableSpeeds() in galaxyfleet.php
6562e9a
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Early return when checking planet's fuel amount
66ad162
mdziekon added a commit that referenced this issue Dec 23, 2020
@mdziekon
GH-139 Create helper function to get fleet slots count
6dd6de5
mdziekon added a commit that referenced this issue May 26, 2022
@mdziekon
GH-139 Simplify empty fleet array check code in fleet3 as well
a361a7b
mdziekon added a commit that referenced this issue May 26, 2022
@mdziekon
GH-139 Remove unused global variable access
6f993ca
mdziekon added a commit that referenced this issue May 26, 2022
@mdziekon
GH-139 Turn validator into parser for reusability
3a4916f
mdziekon added a commit that referenced this issue May 26, 2022
@mdziekon
GH-139 Handle empty fleet array detection in the parser
0d4bee1
mdziekon added a commit that referenced this issue May 26, 2022
@mdziekon
GH-139 Reuse existing fleet validation error message creator
9826ff9
mdziekon added a commit that referenced this issue May 26, 2022
@mdziekon
GH-139 Remove redundant fleet array parsing
d3a8842
mdziekon added a commit that referenced this issue May 26, 2022
@mdziekon
GH-139 Create shared fleet array ships counter
95b5a75
mdziekon added a commit that referenced this issue May 26, 2022
@mdziekon
GH-139 Move storage counter to an util
fb195d3
@mdziekon mdziekon mentioned this issue May 26, 2022
Merged
5 tasks
mdziekon added a commit that referenced this issue May 26, 2022
@mdziekon
Merge pull request #219 from mdziekon/gh-139-fleet-sending-assorted-r…
acce507 
…efactor-06

GH-139 | Refactor flight control | Fleet sending (assorted refactors #6)
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Move max flight's speed getter into an util
0a7f0b0
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Simplify max speed calculation for other steps of fleet sending
edf811e
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Unify max speed calculation in galaxyfleet as well
a688604
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Move speed options renderer into a separate component
bd82c99
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Move union joining attempt calculation into an util
bb8cc7a
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Reuse same union joiner in next step
3ac44b0
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Fix coordinates validator by preventing null values from passing
bded1a0
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Use fleet missions enum more
33d9017
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Move unions list fetcher into an util
c599193
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Add documentation note about callback's expected return
d11c399
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Simplify conditions a bit
b4c1efe
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Pretty input box cleanup
4527e9b
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 More code cleanups
16422d9
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Further code cleanups
481653d
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Simplify target position validation in step two
2b44c0e
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Use flight mission enum
1e63327
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
GH-139 Minor code cleanups
b6251a5
@mdziekon mdziekon mentioned this issue Jun 2, 2022
Merged
6 tasks
mdziekon added a commit that referenced this issue Jun 2, 2022
@mdziekon
Merge pull request #220 from mdziekon/mdziekon/gh-139/flight-control-…
ab66f58 
…refactor-part07

GH-139 | Refactor flight control | Fleet sending (assorted refactors #7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdziekon mdziekon

Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdziekon