Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real phone QA issues #41

Open
mdole opened this issue Nov 22, 2020 · 1 comment
Open

Real phone QA issues #41

mdole opened this issue Nov 22, 2020 · 1 comment

Comments

@mdole
Copy link
Owner

mdole commented Nov 22, 2020

  • Back icon is white on Android
  • On the InputBonusAction screen, adding a new action and clicking "add" results in a TypeError: Invalid attempt to spread non-iterable instance. In order to be iterable, non-array objects must have a [Symbol.iterator]() method this appears to be fixed?? we can no longer replicate. Might have been solved by add optional chaining to character access #40
  • Some elements are moved around up/resized when the keyboard is onscreen:
    • "Save & return" on the profile screen
    • "Saved bonus actions" list on the input bonus actions screen
  • Some buttons are semi-transparent and should be opaque:
    • "Enter a new bonus action" button on both profile & bonus action page
    • Diagonal/Orthogonal buttons on the move screen
    • Buttons on the action screen
    • "Add" button on input bonus action screen
  • We have different strategies for the "Save & return" button on the input bonus action & profile screens. On the former, it hovers just below the content. On the latter, it's near the bottom of the screen.
@muesingb
Copy link
Collaborator

muesingb commented Nov 22, 2020

  • bonus action screen when filling out action/description can't tap out of keyboard view if tapping on parchment background
  • Error from expo:
Error: Problems validating asset fields in app.json. See https://docs.expo.io/
  Field: splash.image - field 'splash.image' should point to .png image but the file at './assets/splash.jpg' has type jpg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants