Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two dimensional deformation getElementProps.F90 #28

Open
benno90 opened this issue Aug 25, 2020 · 2 comments
Open

Two dimensional deformation getElementProps.F90 #28

benno90 opened this issue Aug 25, 2020 · 2 comments

Comments

@benno90
Copy link

benno90 commented Aug 25, 2020

I was using idwarp for two dimensional cases.
In order to work properly I adjusted the file getElementProps.F90.
As faces are lines in two dimensions, the existing algorithm produced a division by zero.
I just added an if statement that computes the areas and normals differently
in case the number of points per face is only.

The main problem is now the differentiation of the file getElementProps.F90
with tapenade. The online conversion tool
is based on version 3.15 wich produces files that are not compatible with version 3.10
that was used to differentiate idwarp.

Do you still have access to version 3.10 of tapenade? Or do you have any other idea
as a workaround?

@eirikurj
Copy link
Contributor

Thanks for creating an issue. Just to clarify, idwarp assumes the mesh is in 3D, i.e., has three dimension x,y,z. This also applies to pseudo 2D meshes (or meshes with x,y,z coordinates, one cell wide), which fits our CFD solver.
Strictly 2D grids (x,y only) are not supported, neither here or in our CFD solver.
Having said that, feel free to extend and submit PRs with new features or bug fixes.
Regarding Tapenade, we currently use 3.10. There is no immediate plan or timeline to move to a newer version.

@benno90
Copy link
Author

benno90 commented Aug 25, 2020

Thanks for your quick reply.
Im happy to submit my modifications as a pull request.
Im currently using idwarp in a pure two dimensional setting where i just set all the z coordinates to zero.
Only a minor modfication to getElementProps.F90 was necessary to get the deformation running.
You can download the modified file here.

My main problem at the moment is to differentiate my modified version of getElementProps.F90
with tapenade as version 3.10 is not available anymore.

If you transform the file and send it back i can also test the adjoint operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants