Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployer): add content-encoding if mimetypes infers one #8498

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Mar 26, 2023

@github-actions github-actions bot added deployer Deployment (currently using AWS S3 and AWS Lambda) python Pull requests that update Python code labels Mar 26, 2023
@yin1999 yin1999 marked this pull request as draft March 26, 2023 08:01
@yin1999 yin1999 marked this pull request as ready for review March 28, 2023 02:59
@caugner
Copy link
Contributor

caugner commented Apr 6, 2023

Triggered a stage-build to test your changes. Once that's finished, https://developer.allizom.org/sitemaps/en-us/sitemap.xml.gz should display properly.

@caugner caugner self-requested a review April 6, 2023 20:38
@caugner
Copy link
Contributor

caugner commented Apr 7, 2023

Once that's finished, https://developer.allizom.org/sitemaps/en-us/sitemap.xml.gz should display properly.

While https://developer.allizom.org/sitemaps/en-us/sitemap.xml.gz displays properly, https://developer.allizom.org/sitemaps/fr/sitemap.xml.gz doesn't. 🤔

But it turns out this is just a side-effect of our deployer only uploading modified files, not taking into consideration the changed metadata. For example, https://developer.allizom.org/sitemaps/ja/sitemap.xml.gz also works.

So I'll go ahead and merge this, even though we're finishing up our migration to GCP in the upcoming weeks, thank you @yin1999!

@caugner caugner changed the title fix(deployer): add content encoding when exists fix(deployer): add content-encoding when mimetypes infers one Apr 7, 2023
@caugner caugner changed the title fix(deployer): add content-encoding when mimetypes infers one fix(deployer): add content-encoding if mimetypes infers one Apr 7, 2023
@caugner caugner merged commit f6ed9a3 into mdn:main Apr 7, 2023
@yin1999 yin1999 deleted the add-content-encoding branch April 7, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployer Deployment (currently using AWS S3 and AWS Lambda) python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompressed sitemaps have incorrect HTTP headers
2 participants