Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix JS for CSS transform-origin example (#2875) #2876

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

lionel-rowe
Copy link
Contributor

Description

From linked issue:

The examples in the interactive example at https://developer.mozilla.org/en-US/docs/Web/CSS/transform-origin are supposed to rotate, but they don't any more.

Motivation

Fix examples.

Additional details

Also added clarifying comment to 4th example, which uses a different transform.

Related issues and pull requests

Fixes #2875.

@lionel-rowe lionel-rowe requested a review from a team as a code owner December 10, 2024 04:26
@lionel-rowe lionel-rowe requested review from chrisdavidmills and removed request for a team December 10, 2024 04:26
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this locally, and it works fine. Thanks a lot for the fix @lionel-rowe, let's get this merged!

@chrisdavidmills chrisdavidmills merged commit 92c1c7a into mdn:main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transform-origin example is broken
2 participants