Fix double allocation in typedarray-of.js #2611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current example for TypedArray.of() allocates an empty array first, before invoking the static
of()
method. My fix removes that unnecessary and misleading initial allocation.Motivation
A novice user might look at the current example code and infer that they need to create a new typed array first before they can use the
of()
method. That is not the case. Also, simpler is better.Additional details
I replaced
with
to avoid the unnecessary allocation of the empty array.
Related issues and pull requests
n/a