Fix text-underline-offset example in Safari #2601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
text-decoration
shorthand withtext-decoration-line
andtext-decoration-color
intext-underline-offset.css
Motivation
text-underline-offset
example currently appears broken in Safari because of it not supportingtext-decoration
shorthand without-webkit-
prefixAdditional details
Alternative could be to add
-webkit-
prefixed version oftext-decoration
property+ -webkit-text-decoration: underline #ff0000; text-decoration: underline #ff0000;
However a solution that doesn’t require a vendor prefix seems preferable.