Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SnapPicture functionality #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mdmfernandes
Copy link
Owner

@mdmfernandes mdmfernandes commented Oct 2, 2024

Get a snapshot from the camera.

The data returned by the camera is validated with MIME sniffing [1], and returned in a byte slice.

  1. https://mimesniff.spec.whatwg.org/

To do

  • Create function for FI8919w
  • Add unit tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.98%. Comparing base (6aebe08) to head (702c9cf).

Files with missing lines Patch % Lines
fi9800p.go 25.00% 6 Missing ⚠️
fi8919w.go 33.33% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   91.01%   81.98%   -9.03%     
==========================================
  Files           5        6       +1     
  Lines          89      111      +22     
==========================================
+ Hits           81       91      +10     
- Misses          8       18      +10     
- Partials        0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Get a snapshot from the camera.

The data returned by the camera is validated with MIME sniffing [1], and
returned in a byte slice.

1. https://mimesniff.spec.whatwg.org/

Update cameras config, since the query strings may vary from camera to
camera.
@mdmfernandes mdmfernandes force-pushed the add-snappicture branch 2 times, most recently from 112e517 to 442385d Compare October 11, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants