Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] detect new and stopped containers during runtime #89

Open
tsfoer opened this issue Jan 28, 2020 · 3 comments
Open

[Feature] detect new and stopped containers during runtime #89

tsfoer opened this issue Jan 28, 2020 · 3 comments

Comments

@tsfoer
Copy link

tsfoer commented Jan 28, 2020

Currently ofelia is only capable of detecting containers during startup. Stopped or destroyed containers are also not detected leading to errors like:

common.go:117 ▶ ERROR [Job "testjob" (4ffe34388a00)] Finished in "3.3764ms", failed: true, skipped: false, error: error creating exec: No such container: hopeful_gates

This could be fixed if ofelia would detect container starts and stops during its runtime which also would extend the overall utility of ofelia (maybe by polling the socket every X seconds or listening to events on the socket).

@rdelcorro
Copy link

I am using docker labels and ofelia reads it once and never again. If you change the command, modify the schedule, even remove the labels, it does not detect it. You have to restart ofelia, which is not great as it may be running some other job. Ideally jobs should be updated dynamically, the same way you add a task. Adding it on this feature request as I do also see the same behavior when I stop the container. The job is still being scheduled

@rdelcorro
Copy link

I have fixed this here: #137

@4n70w4
Copy link

4n70w4 commented Jul 10, 2021

similar: #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants