Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this repository still active? #66

Closed
eleaner opened this issue Mar 16, 2019 · 24 comments
Closed

is this repository still active? #66

eleaner opened this issue Mar 16, 2019 · 24 comments

Comments

@eleaner
Copy link

eleaner commented Mar 16, 2019

There is a raft of questions and nobody seems to be answering them e.g. #21

@hongkongkiwi
Copy link

I can't comment on authors code writing (last commit was 10 months ago), but generally the questiosn are more like doing stuff in docker itself (run docker from docker, pass in credentials or mounted volumes, private auth of containers etc). So it appears there are not many actual bug reports outstanding, just general howto questions.

@taraspos
Copy link
Collaborator

taraspos commented Mar 24, 2019

I made a fork, implemented some additional features I need (reading configurations from the docker labels).
I could send a PR, but I doubt it will be merged.
My fork also has all the pending PRs (#48 #49 #59) and some issues (#32) resolved

https://github.com/Trane9991/ofelia.
Technically, I could create a new repo and maintain it.

@djpbessems
Copy link

Seeing as there doesn't really seem to be any similar tool for scheduling jobs within a docker-infrastructure, I'm hoping Ofelia will remain maintained (if only for the fact that mcuadros' dockerimage on dockerhub is based on an outdated golang image).

I've forked Trane's repo for now to base my CI on (https://hub.docker.com/r/djpbessems/ofelia)

@hiphamster
Copy link

Is it possible to specify docker run options inside config.ini? It would be great to be able to mount volumes on the run or build an image with something like 'context'

@hiphamster
Copy link

Ofelia does not find my local image - i get 'error pulling image "docker_panda_python": API error (404) ...."
[job-run "service-executed-on-new-container"]
image = docker_panda_python

docker_panda_python image in fact exists.

@djpbessems
Copy link

djpbessems commented Apr 18, 2019

I'm guessing you haven't started Ofelia with access to /var/run/docker.sock?

And just a headsup, your questions should be in a seperate issue, not in this one where we are discussing how this repository can be maintained.

@hiphamster
Copy link

@djpbessems Thanks for reply. I'll create a separate issue for my questions. In regards to docker.sock, ofelia does have access to it, 'job-exec' on an existing container works perfectly well.

@hiphamster
Copy link

hiphamster commented Apr 18, 2019 via email

@colthreepv
Copy link

@trane9991 have you tried contacting @mcuadros to be upped as maintainer on this project?

When considering a tool to choose it's really critical to be able to rely on a maintained project

@mcuadros
Copy link
Owner

I open to let other people to maintain the project.

@taraspos
Copy link
Collaborator

@mcuadros I'm a bit busy right now, but I was planning to maintain it.
How do you see the best way to do that?

@dominikkv
Copy link

@mcuadros please make it happen :-)

@kerphi
Copy link

kerphi commented Oct 2, 2019

@mcuadros did you opened ofelia to other motivated maintainers? for example: @trane9991 ?

@mcuadros
Copy link
Owner

mcuadros commented Oct 8, 2019

Hi @trane9991 is just sent you an invitation for colaborate! thanks for caring

@taraspos
Copy link
Collaborator

taraspos commented Oct 8, 2019

Thanks, @mcuadros!
Accepted it.

one more question, how is a push to the https://hub.docker.com/r/mcuadros/ofelia happening?
Is there are automatic build configured or you used to do this manually?

@mcuadros
Copy link
Owner

mcuadros commented Oct 8, 2019

It's an automated build, so should be done in push

@kerphi
Copy link

kerphi commented Nov 1, 2019

@trane9991 do you plan to merge the work you did on your own Ofelia fork?
It would be great!

@taraspos
Copy link
Collaborator

taraspos commented Nov 2, 2019

Yup will do that!
However, there is a bit more work I want to do before merging like moving to go mod, removing vendor directory that I have in my fork, etc.

However, as far as I see automatic Docker Hub build is not triggered :( so merge of my fork will not update the docker image. @mcuadros any chance you can help me with that? I don't have permissions to the repo to fix it...

@kerphi
Copy link

kerphi commented Nov 2, 2019

@mcuadros @trane9991 for docker hub auto build you could change the docker hub account to an organization account so you can give admin access to several user account easily.

@taraspos
Copy link
Collaborator

taraspos commented Nov 4, 2019

My fork changes merged, however, build on Docker hub still doesn't work :(

@mcuadros
Copy link
Owner

mcuadros commented Nov 4, 2019 via email

@mcuadros
Copy link
Owner

mcuadros commented Nov 4, 2019 via email

@taraspos
Copy link
Collaborator

taraspos commented Aug 4, 2020

@trane9991 it looks like you abandoned maintaining this repository in favor of your own fork. Can you confirm that ? I'm just picking this up, and I'd rather not bet on the wrong horse.

Nope. If you can check my fork on the Github, the last commit is Nov 2, 2019.

But I'm not doing active development on the repo as well. I'm trying my best to answer the questions in the issues when I have time. However, I'm not the original developer and I do not know codebase perfectly.
I'm also not going to pick up any major feature requests for now, since I do not have enough time for that.
But if you will prepare PR with the feature you need I will do my best to review and merge it.

Thanks.

@Gaibhne
Copy link

Gaibhne commented Aug 4, 2020

Yeah, my apologies. I looked at the commit dates wrong, and when I realized my mistake, I removed my comment - but apparently not fast enough for you to not see it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants