Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a live indicator #9

Open
mcrumm opened this issue Oct 7, 2021 · 2 comments
Open

Display a live indicator #9

mcrumm opened this issue Oct 7, 2021 · 2 comments
Milestone

Comments

@mcrumm
Copy link
Owner

mcrumm commented Oct 7, 2021

I am thinking we could display the status-online icon in place of the duration measurement when the liveview is connected. (Something like .phxweb-toolbar-view.phx-connected .phxweb-toolbar-live{ display: inline } and hide the rest)

@leandrocp
Copy link
Collaborator

leandrocp commented Oct 15, 2021

Do you have plans to show if LV has entered in the fail safe mode? I see it's not useful to everyone to have such information but we had cases where websocket was blocked on the client and we had to simulate and deal with that scenario (displaying a warning page, dispatching notification and stuff like that), so it could be useful.
There's no public API to fetch this information from LV, except for https://github.com/phoenixframework/phoenix_live_view/blob/afdee17134699f792b41f98e220cef1805b041f8/assets/js/phoenix_live_view/live_socket.js#L271

@mcrumm
Copy link
Owner Author

mcrumm commented Oct 15, 2021

I think that's a great idea! We'll need to be able to differentiate between a disconnected LiveView and a stateless request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants