Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending messages might just resend unload bomb without user pressing button #7

Open
mcr222 opened this issue Oct 28, 2017 · 0 comments
Labels

Comments

@mcr222
Copy link
Owner

mcr222 commented Oct 28, 2017

The messages that could not be sent are stored and tried to be resend. For the unloadBomb messages this might not be a good idea, since it might resend messages uncontrollably. I think that one approach would be to treat separately unloadBomb messages, since there are other issues (like sending to multiple phones the bomb).

Additinally: //TODO: important, no resending messages of unload bomb when phone is locked, since then it bomb could be
//TODO: send by the phone when resending messages (this case is protected by the fact that messages are only
//TODO: resend when user presses send button

@mcr222 mcr222 added the bug label Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant