From 2ee4e2e5dbc85ca050bffed65196e0c99f71bb32 Mon Sep 17 00:00:00 2001 From: MonsieurNicolas Date: Wed, 25 Apr 2018 17:44:12 -0700 Subject: [PATCH] revert change to PendingEnvelopes::addSCPQuorumSet change introduced in d1b33a4da3daf9938e7a03873c4faea4fa94cd49 was wrong hash was the hash of a quorum set not the hash of a node --- src/herder/PendingEnvelopes.cpp | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/herder/PendingEnvelopes.cpp b/src/herder/PendingEnvelopes.cpp index b0647fd07a..a95fe69d82 100644 --- a/src/herder/PendingEnvelopes.cpp +++ b/src/herder/PendingEnvelopes.cpp @@ -66,16 +66,7 @@ PendingEnvelopes::addSCPQuorumSet(Hash hash, const SCPQuorumSet& q) CLOG(TRACE, "Herder") << "Add SCPQSet " << hexAbbrev(hash); SCPQuorumSetPtr qset(new SCPQuorumSet(q)); - if (mQsetCache.exists(hash)) - { - // force recomputation of transitive quorum information as it may change - // "not in quorum" into "in quorum". - // the "quorum -> not in quorum" is similar to the case of a new quorum - // set, where the only thing it can do is turn - // a "maybe" (true) into "no" (false) which doesn't matter within - // a round (clear will happens regardless when the slot is externalized) - mNodesInQuorum.clear(); - } + mNodesInQuorum.clear(); mQsetCache.put(hash, qset); mQuorumSetFetcher.recv(hash);