Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload: Fix mbed_adjust_upload_debug_commands for multiple targets #391

Conversation

ccli8
Copy link

@ccli8 ccli8 commented Nov 21, 2024

Summary of changes

The purpose of mbed_adjust_upload_debug_commands() is to adjust first version of MBED_UPLOAD_LAUNCH_COMMANDS. For multiple executalbe cmake targets, MBED_UPLOAD_LAUNCH_COMMANDS becomes not fresh and may cause error. To overcome this, one new cmake cache variable MBED_UPLOAD_LAUNCH_COMMANDS_BAK is introduced to save first version of MBED_UPLOAD_LAUNCH_COMMANDS.

Fix #383


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

The purpose of mbed_adjust_upload_debug_commands() is to adjust
first version of MBED_UPLOAD_LAUNCH_COMMANDS. For multiple executalbe
cmake targets, MBED_UPLOAD_LAUNCH_COMMANDS becomes not fresh and may
cause error. To overcome this, one new cmake cache variable
MBED_UPLOAD_LAUNCH_COMMANDS_BAK is introduced to save first version of
MBED_UPLOAD_LAUNCH_COMMANDS.
@JojoS62
Copy link

JojoS62 commented Nov 21, 2024

tested with adding a 3rd target, works as expected. Thanks for the quick fix.

@multiplemonomials multiplemonomials merged commit ab43414 into mbed-ce:master Nov 21, 2024
52 checks passed
@ccli8 ccli8 deleted the fix_debug_launch_load_for_multiple_targets branch November 22, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug configuration for mutilple targets adds wrong overrideLaunchCommands
3 participants