[BSSTELE] The Hideout! - creash when two users connect via rlogin

[ftoledo]

Module Information

• Identifier BSSTELE
• Module Name The Hideout
• Version 1.5

Describe the bug
I run Synchronet BBS and call via rlogin to mbbsemu, I connect from two users to the module port and crash the emu

I'm still not sure if this related to that particular module.

To Reproduce
Connect via rlogin (dynamic created ports) from two users

Expected behavior
both user must enter to the Teleconference

Screenshots

[2025-01-04T22:20:31.3323750-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-2: 0002:7F64
[2025-01-04T22:20:32.0580619-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-1: 0002:7D5E
[2025-01-04T22:20:32.1659948-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-1: 0002:826E
[2025-01-04T22:20:32.3582572-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-0: 0002:7F64
[2025-01-04T22:20:33.3845812-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-1: 0002:7F64
[2025-01-04T22:20:33.8242489-03:00] MBBSEmu.Server.Socket.SocketServer [Information] Accepting incoming Rlogin connection from 127.0.0.1:59561...
[2025-01-04T22:20:33.8247255-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Session 127.0.0.1:59561 added to incoming queue
[2025-01-04T22:20:33.8250514-03:00] MBBSEmu.Session.Rlogin.RloginSession [Information] Rlogin For User: Ftoledo
[2025-01-04T22:20:33.8251599-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Added Session 127.0.0.1:59561 to channel 0
[2025-01-04T22:20:33.8252508-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Calling lonrou on module DIALCHAT for channel 0
[2025-01-04T22:20:34.0857365-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-0: 0002:7D5E
[2025-01-04T22:20:34.4095098-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-0: 0002:7F64
[2025-01-04T22:20:35.1911354-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-2: 0002:826E
[2025-01-04T22:20:35.4338176-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-1: 0002:7F64
[2025-01-04T22:20:36.1104321-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-1: 0002:7D5E
r[2025-01-04T22:20:36.4619581-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-2: 0002:7F64
[2025-01-04T22:20:37.4884825-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Running RTKICK-1: 0002:7F64
[2025-01-04T22:20:37.5837522-03:00] MBBSEmu.Server.Socket.SocketServer [Information] Accepting incoming Rlogin connection from 127.0.0.1:56047...
[2025-01-04T22:20:37.5848917-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Session 127.0.0.1:56047 added to incoming queue
[2025-01-04T22:20:37.5853040-03:00] MBBSEmu.HostProcess.MbbsHost [Information] Added Session 127.0.0.1:56047 to channel 1
Unhandled exception. System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
   at System.Collections.Generic.Dictionary`2.ValueCollection.Enumerator.MoveNext()
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at MBBSEmu.Session.Rlogin.RloginSession.ProcessIncomingByte(Byte b) in /sbbs/mbbsemu/src/MBBSEmu/MBBSEmu/Session/Rlogin/RloginSession.cs:line 87
   at MBBSEmu.Session.Rlogin.RloginSession.ProcessIncomingClientData(Byte[] clientData, Int32 bytesReceived) in /sbbs/mbbsemu/src/MBBSEmu/MBBSEmu/Session/Rlogin/RloginSession.cs:line 141
   at MBBSEmu.Session.SocketSession.ProcessIncomingClientData(Int32 bytesReceived) in /sbbs/mbbsemu/src/MBBSEmu/MBBSEmu/Session/SocketSession.cs:line 182
   at MBBSEmu.Session.SocketSession.OnReceiveData(IAsyncResult asyncResult) in /sbbs/mbbsemu/src/MBBSEmu/MBBSEmu/Session/SocketSession.cs:line 160
   at System.Threading.Tasks.TaskToAsyncResult.TaskAsyncResult..ctor(Task task, Object state, AsyncCallback callback)
   at System.Threading.Tasks.TaskToAsyncResult.Begin(Task task, AsyncCallback callback, Object state)
   at System.Net.Sockets.Socket.BeginReceive(Byte[] buffer, Int32 offset, Int32 size, SocketFlags socketFlags, AsyncCallback callback, Object state)
   at MBBSEmu.Session.SocketSession.ListenForData() in /sbbs/mbbsemu/src/MBBSEmu/MBBSEmu/Session/SocketSession.cs:line 202
   at MBBSEmu.Session.SocketSession.Start() in /sbbs/mbbsemu/src/MBBSEmu/MBBSEmu/Session/SocketSession.cs:line 37
   at MBBSEmu.Server.Socket.SocketServer.OnNewConnection(IAsyncResult asyncResult) in /sbbs/mbbsemu/src/MBBSEmu/MBBSEmu/Server/Socket/SocketServer.cs:line 97
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.AwaitTaskContinuation.RunCallback(ContextCallback callback, Object state, Task& currentTask)
--- End of stack trace from previous location ---
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
Abortado

Software Information:

• OS: debian 12
• Telnet Client: syncterm