Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for modernizing the training scripts available in the repository #11

Open
mbarbetti opened this issue Jul 2, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers python Pull requests that update Python code

Comments

@mbarbetti
Copy link
Owner

The Python scripts contained in pidgan/scripts are intended for preparing the set of models required to parameterize the high-level response (i.e., flash-simulation) of the LHCb PID system. Even if perfectly functional, they are quite rude and may benefit from some code enhancement.

For example, they do not implement any proper logging system, preferring to trace the program execution by using the print() function. A generic user may deeply benefit from the use of a modern logging package like Loguru or one of the others described in this highlight.io post.

Or again, each Python script requires a minimal CLI that is currently implemented through the Python built-in argparse module. The same CLI can be easily implemented by using Typer with great benefits as highlighted by Marie Stephen Leo in this LinkedIn post.

1718806182954

@mbarbetti mbarbetti added enhancement New feature or request good first issue Good for newcomers python Pull requests that update Python code labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant