Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using subprocess to run dimorphite_dl #37

Open
eladnoor opened this issue Jan 15, 2023 · 2 comments
Open

Using subprocess to run dimorphite_dl #37

eladnoor opened this issue Jan 15, 2023 · 2 comments

Comments

@eladnoor
Copy link

Hello,

I've noticed that Dimorphite-DL is called via subprocess, although it is a python script and can probably be called directly as an imported package, which should be more efficient.

I can try to change it myself if this makes sense.

@mayrf
Copy link
Owner

mayrf commented Jan 15, 2023

Hello,

thanks for the initiative, yes that would indeed be much better! Yeah, I would appreciate, if you'd be willing to try it!

@eladnoor
Copy link
Author

eladnoor commented Jan 16, 2023

Okay, it was quite easy to do. You can see the changes in this fork:
main...eladnoor:pkasolver:main

I think it is working the same as before, however when I try running test_query, I get mostly errors. I am not sure, but I think the problem exists already in your branch - looking at the CI a lot of tests are skipped (exactly the ones that fail on my machine): https://github.com/mayrf/pkasolver/actions/runs/3926198791/jobs/6711694088#step:6:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants