Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make some dependencies optional #67

Open
sergei-maertens opened this issue Sep 3, 2024 · 2 comments
Open

Please make some dependencies optional #67

sergei-maertens opened this issue Sep 3, 2024 · 2 comments
Labels
triage Triage means the team has not yet refined this issue.

Comments

@sergei-maertens
Copy link
Member

We will use this dependency in https://github.com/GeneriekPublicatiePlatformWoo/registratie-component and I'm seeing some dependencies that are problematic or just plain not needed. Can you please put these in optional dependency groups so that you can install with pip install open-api-framework[pscyopg2,celery] etc.?

Dependencies that caught my eye

  • django-cors-headers: not necessary for this project, since it will only consumed by backend servers and thus CORS does not apply
  • django-markup: we will not have templates that need to render markdown
  • django-redis: Django has built-in support for redis cache now, a third party dependency is not necessarily needed
  • djangorestframework-gis: no geo-stuff is relevant to this project
  • django-csp: no public UI or DigiD requirements are relevant, CSP will not be applied, maybe in the future
  • djangorestframework-inclusions: we will not need this
  • commonground-api-common: this one in particular will pull in a lot of deprecated/outdated stuff and there's nothing in there of interest for this project
  • psycopg2 conflicts with psycopg 3, which is the successor
  • bleach: we will not be rendering WYSIWYG content that requires sanitation
  • uwsgi seems odd to require this here, what if someone wants to use gunicorn or daphne for ASGI support (okay, far fetched, but doesn't belong in this list IMO)
  • celery: definitely excluding this from the project as long as possible
  • flower: tied to celery, so see above
@alextreme alextreme added the triage Triage means the team has not yet refined this issue. label Sep 10, 2024
@alextreme
Copy link
Member

Valid concerns, we'll discuss them within Team Bron.

CSP is relevant due to audits like https://taiga.maykinmedia.nl/project/gemeente-amsterdam/issue/18 . It does need to be set correctly though (eg. #68 )

@alextreme
Copy link
Member

Discussed, regarding django-redis and psycopg2 it would be better to remove (redis) and update (to psycopg3) instead of adding optional dependancies

Will leave in triage to discuss broader with Team bron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Triage means the team has not yet refined this issue.
Projects
Status: Triage
Development

No branches or pull requests

2 participants