Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the validation rsin and bsn so that it can also be used by other projects #57

Open
danielmursa-dev opened this issue Dec 30, 2024 · 0 comments · May be fixed by #58
Open

Improving the validation rsin and bsn so that it can also be used by other projects #57

danielmursa-dev opened this issue Dec 30, 2024 · 0 comments · May be fixed by #58

Comments

@danielmursa-dev
Copy link

The issue/feature comes from this issue maykinmedia/open-klant#233, where multiple similar objects have to be validated, so I try to optimise this by creating a generic validator that can also be used by other systems.
danielmursa-dev added a commit that referenced this issue Dec 30, 2024
@danielmursa-dev
[#57] Create BaseValidator
454080a
danielmursa-dev added a commit that referenced this issue Dec 30, 2024
@danielmursa-dev
[#57] Delete old function
65ee076
danielmursa-dev added a commit that referenced this issue Dec 30, 2024
@danielmursa-dev
[#57] Delete old import
b59ba7e
danielmursa-dev added a commit that referenced this issue Dec 30, 2024
@danielmursa-dev
[#57] Fix import
622b8fc
@danielmursa-dev danielmursa-dev linked a pull request Dec 30, 2024 that will close this issue
Open
danielmursa-dev added a commit that referenced this issue Dec 30, 2024
@danielmursa-dev
[#57] Create tests
a405edf
danielmursa-dev added a commit that referenced this issue Dec 30, 2024
@danielmursa-dev
[#57] Fix tests
f490f00
danielmursa-dev added a commit that referenced this issue Dec 30, 2024
@danielmursa-dev
[#57] Fix tests
e43b0bc
danielmursa-dev added a commit that referenced this issue Dec 30, 2024
@danielmursa-dev
[#57] Create BaseValidator
3d35fa4 
[#57] Delete old function

[#57] Delete old import

[#57] Fix import

[#57] Create tests

[#57] Fix tests

[#57] Fix tests
danielmursa-dev added a commit that referenced this issue Jan 6, 2025
@danielmursa-dev
[#57] Fix naming
1e29728
danielmursa-dev added a commit that referenced this issue Jan 7, 2025
@danielmursa-dev
[#57] Fix validator
4cc3883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improving the validation rsin and bsn maykinmedia/commonground-api-common
1 participant
@danielmursa-dev