Check if projects have custom names for the celery workers/queues

[SilviaAmAm]

Discussion: https://github.com/maykinmedia/charts/pull/164/files#r1914893573

Most projects use this to start celery:

QUEUE=${1:-${CELERY_WORKER_QUEUE:=celery}} 
WORKER_NAME=${2:-${CELERY_WORKER_NAME:="${QUEUE}"@%n}}

exec celery --workdir src --app proj.celery worker \
    -Q $QUEUE \
    -n $WORKER_NAME \
   ...

Projects that need changing:

• Open forms
• Open zaak
• Open notificaties
• Open inwoner
• Objecten
• Open archiefbeheer
• Open klant

[SilviaAmAm]

Spent some time understanding how the celery_worker.sh works:

• if /celery_worker.sh is called with positional args (/celery_worker.sh apple potato), this takes precedence and gives a worker celery@apple listening to queue potato.
  Note: if the worker name does not contain the symbol @, it is considered the hostname and celery@ is prepended to it: https://github.com/celery/celery/blob/fe761416f4d9269b780a13cc1131e2a16945937f/celery/utils/nodenames.py#L79
• If there are no positional arguments and the environment variables CELERY_WORKER_QUEUE and WORKER_NAME are set, then those will be used.
• If nothing is set, it defaults to worker celery@hostname listening to queue celery.

The way the script celery_worker.sh is run in the helm charts doesn't use the positional args, so I guess there is no need to support this possibility (at least for now).

The celery docs don't mention that the hostname "must" include a @ symbol, so then we should also in the helm chart figure out if the we need to use celery@${WORKER_NAME} or ${WORKER_NAME} or celery@${HOSTNAME}

Edit after discussion with Sergei:

In celery, the -Q option can be a comma separated list of strings so that workers can listen to multiple queues (https://docs.celeryq.dev/en/v5.4.0/reference/cli.html#cmdoption-celery-worker-Q). We don't support this with the celery_worker.sh script. We use the CELERY_WORKER_QUEUE variable to set the name of a queue per worker. In our ansible deployments, it is possible to define multiple worker containers that listen to different queues. In the helm charts this is not yet supported, but should be kept in mind for now.

[sergei-maertens]

I'm open for simplifying things and dropping support for positional arguments if it's not used anywhere!

[SilviaAmAm]

I checked: our charts don't use them, and our ansible deployments also don't use them. I will simplify the scripts.

To do:

• Open forms 🔥 Remove unused celery command line args open-formulieren/open-forms#5029
• Open zaak 🔥 Remove unused command line args open-zaak/open-zaak#1865
• Open notificaties 🔥 Remove unused celery command line args open-zaak/open-notificaties#225
• Open inwoner 🔥 Remove unused celery command line args open-inwoner#1571
• Objecten 🔥 Remove unused celery command line args objects-api#520
• Open archiefbeheer 🔥 [maykinmedia/charts#165] Remove unused command line args open-archiefbeheer#634
• Open klant 🔥 Remove unused command line args open-klant#322
• Default project https://bitbucket.org/maykinmedia/default-project/pull-requests/157

[SilviaAmAm]

Only OAB complete