Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Add validation so that subcategories are always the same color as the parent #1668

Open
zachgoll opened this issue Jan 23, 2025 · 1 comment · May be fixed by #1722
Open

Improvement: Add validation so that subcategories are always the same color as the parent #1668

zachgoll opened this issue Jan 23, 2025 · 1 comment · May be fixed by #1722
Labels
Community This is a great issue for community members to work on 2️⃣ Medium Priority Community contributions accepted, Maybe team only works on if there are no high priority items open

Comments

@zachgoll
Copy link
Collaborator

Currently, we allow users to have different colors for parent/subcategories. This creates a visually confusing UI; especially in the budgets section.

Image

Image

Solution

  • Add validation to ensure subcategory always gets assigned color of parent
  • Update category form to reflect this validation
@zachgoll zachgoll added 🎨 Frontend 2️⃣ Medium Priority Community contributions accepted, Maybe team only works on if there are no high priority items open Community This is a great issue for community members to work on and removed 🎨 Frontend labels Jan 23, 2025
@JLambertazzo JLambertazzo linked a pull request Jan 28, 2025 that will close this issue
Open
@JLambertazzo
Copy link
Contributor

Hey! I tried to complete this task, opened a draft with what I have so far. The validation is working well but the form updates are only happening after a submission, not when a parent is selected from the dropdown.

My work is on #1722. If you can point me to a resource for how reactivity to the dropdown selection could be achieved, I'd be happy to keep trying tomorrow! Otherwise if someone wants to collaborate/take over, by all means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Community This is a great issue for community members to work on 2️⃣ Medium Priority Community contributions accepted, Maybe team only works on if there are no high priority items open
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure Consistent Category Colors JLambertazzo/maybe
2 participants
@zachgoll @JLambertazzo